Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT use inference_mode instead of no_grad #161

Merged
merged 4 commits into from
May 2, 2024
Merged

FEAT use inference_mode instead of no_grad #161

merged 4 commits into from
May 2, 2024

Conversation

jalew188
Copy link
Collaborator

@jalew188 jalew188 commented May 1, 2024 •
edited
Loading

@jalew188 jalew188 requested review from GeorgWa and mo-sameh May 1, 2024 07:40
mo-sameh
mo-sameh approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@mo-sameh mo-sameh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should raise the torch requirement to v1.9.0 to prevent any dependency issues.
Other that LGTM.

@jalew188 jalew188 merged commit 4c06758 into development May 2, 2024
6 checks passed
@jalew188 jalew188 deleted the inference_mode branch May 29, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgWa GeorgWa GeorgWa approved these changes

@mo-sameh mo-sameh mo-sameh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jalew188 @GeorgWa @mo-sameh