Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greek translation #156

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Greek translation #156

merged 3 commits into from
Nov 9, 2021

Conversation

getimiskon
Copy link

I decided to create a Greek translation for the program. I tried to create a translation through POEditor, but it seems weird to use, and for the size of the project doing the changes manually with a text editor isn't hard at all.

Some strings that contain the word "instance" have been untranslated in purpose because there is no translation for that context.

@ManeraKai
Copy link
Owner

ManeraKai commented Nov 3, 2021

There are some discussions on replacing POEditor.

The word server is a good replacement. I translate the word instance in Arabic but add after it between parenthesis the word server to help explain. i.e: This instance (server) is an official one.

@Valdnet Valdnet added the translation Improvement, bug or adding a translation label Nov 3, 2021
@Valdnet Valdnet added this to the v1.1.3 milestone Nov 3, 2021
@Valdnet Valdnet requested review from Valdnet and ManeraKai November 3, 2021 07:29
@getimiskon
Copy link
Author

getimiskon commented Nov 3, 2021

The word server is a good replacement. I translate the word instance in Arabic but add after it between parenthesis the word server to help explain. i.e: This instance (server) is an official one.

I have been thinking of that when I was translating the text. I will do the changes to the translation later today.

There are some discussions on replacing POEditor.

I see... It seemed rather cumbersome to use at first. It's easy to mess up if you don't know the interface there. For example, it's easy to accidentally apply as a contributor to a language that you don't even understand, for some reason.

@ManeraKai
Copy link
Owner

In the turkish translation, the translator added quotes to the word instance.
Ex: Check instance. => "Instance" kontrol et"

@Valdnet
Copy link
Collaborator

Valdnet commented Nov 8, 2021

I have been thinking of that when I was translating the text. I will do the changes to the translation later today.

@getimiskon Can we count on you to improve the translation for "Instance"?

@getimiskon
Copy link
Author

I'm sorry for being late to respond and to upload the commit.

I updated the translation for the "instance" by replacing them with the Greek word for "server", as well as doing a few small changes to some translations.

Copy link
Owner

@ManeraKai ManeraKai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManeraKai
Copy link
Owner

LGTM. Thanks @getimiskon!

@ManeraKai ManeraKai merged commit f9c37e1 into ManeraKai:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Improvement, bug or adding a translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants