Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation into Polish and correct spelling #121

Merged
merged 7 commits into from
Oct 8, 2021
Merged

Update translation into Polish and correct spelling #121

merged 7 commits into from
Oct 8, 2021

Conversation

Valdnet
Copy link
Collaborator

@Valdnet Valdnet commented Oct 8, 2021

No description provided.

@Valdnet Valdnet added the translation Improvement, bug or adding a translation label Oct 8, 2021
@Valdnet Valdnet added this to the v1.1.2 milestone Oct 8, 2021
@Valdnet Valdnet requested a review from ManeraKai October 8, 2021 07:34
lang/main_en.arb Outdated
@@ -115,7 +115,7 @@
"enter_text_here": "Enter text here",
"something_went_wrong": "Something went wrong",
"check_instance": "Check instance.",
"check_instnace_audio": "Check instance and its tts (text-to-speach) support.",
"check_instnace_audio": "Check instance and its TTS (Text-To-Speech) support.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks better.

@ManeraKai
Copy link
Owner

ManeraKai commented Oct 8, 2021

Can you change the string's key name to have tts?

@Valdnet
Copy link
Collaborator Author

Valdnet commented Oct 8, 2021

It is an abbreviation of Speech. In my opinion, it should be in capital letters. Only Text-To-Speech should be changed to Text-to-Speech.

@ManeraKai
Copy link
Owner

??
I mean this:
check_instnace_audio
to
check_instnace_tts

@Valdnet
Copy link
Collaborator Author

Valdnet commented Oct 8, 2021

Ah. Ok. I'll change that in a moment.

@Valdnet
Copy link
Collaborator Author

Valdnet commented Oct 8, 2021

Ok. I changed. Before combining squash 😉.

@ManeraKai
Copy link
Owner

ManeraKai commented Oct 8, 2021

Arabic and here: https://github.com/ManeraKai/simplytranslate_mobile/blob/main/lib/data.dart#L164 too 😁

@ManeraKai ManeraKai merged commit 2c048be into ManeraKai:main Oct 8, 2021
@Valdnet
Copy link
Collaborator Author

Valdnet commented Oct 8, 2021

Done 😁.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Improvement, bug or adding a translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants