Linestyle type

[SimonDanisch]

Continuation of #3135

[MakieBot]

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))

	using	create	display	create	display
GLMakie	10.98s (10.94, 11.03) 0.05+-	1.20s (1.19, 1.21) 0.01+-	728.64ms (716.56, 780.63) 23.04+-	9.69ms (9.58, 9.75) 0.07+-	138.44ms (137.88, 139.54) 0.52+-
master	10.96s (10.87, 11.04) 0.07+-	1.21s (1.20, 1.22) 0.00+-	706.25ms (696.98, 726.40) 11.91+-	9.68ms (9.65, 9.73) 0.03+-	138.76ms (137.81, 140.07) 0.81+-
evaluation	+0.22%, 0.02s invariant (0.42d, 0.44p, 0.06std)	-0.74%, -0.01s faster ✓ (-1.59d, 0.01p, 0.01std)	+3.07%, 22.4ms slower X (1.22d, 0.05p, 17.48std)	+0.04%, 0.0ms invariant (0.06d, 0.91p, 0.05std)	-0.23%, -0.32ms invariant (-0.47d, 0.40p, 0.67std)
CairoMakie	11.20s (10.93, 11.62) 0.21+-	1.19s (1.15, 1.27) 0.04+-	234.34ms (225.46, 250.02) 8.73+-	11.07ms (10.91, 11.34) 0.16+-	4.67ms (4.57, 4.75) 0.06+-
master	11.24s (11.07, 11.60) 0.19+-	1.20s (1.16, 1.23) 0.02+-	233.36ms (225.42, 247.87) 7.12+-	11.13ms (11.00, 11.31) 0.12+-	4.65ms (4.62, 4.72) 0.04+-
evaluation	-0.35%, -0.04s invariant (-0.20d, 0.72p, 0.20std)	-0.87%, -0.01s invariant (-0.29d, 0.59p, 0.03std)	+0.42%, 0.98ms invariant (0.12d, 0.82p, 7.93std)	-0.54%, -0.06ms invariant (-0.42d, 0.44p, 0.14std)	+0.31%, 0.01ms invariant (0.27d, 0.62p, 0.05std)
WGLMakie	12.38s (12.26, 12.53) 0.13+-	1.35s (1.31, 1.40) 0.03+-	11.66s (11.45, 11.90) 0.17+-	13.25ms (12.29, 14.56) 0.85+-	1.05s (0.99, 1.13) 0.04+-
master	12.40s (12.26, 12.65) 0.13+-	1.35s (1.32, 1.38) 0.03+-	11.65s (11.51, 11.94) 0.14+-	13.19ms (12.25, 13.82) 0.56+-	1.07s (1.02, 1.13) 0.05+-
evaluation	-0.16%, -0.02s invariant (-0.15d, 0.78p, 0.13std)	+0.34%, 0.0s invariant (0.16d, 0.77p, 0.03std)	+0.07%, 0.01s invariant (0.05d, 0.93p, 0.15std)	+0.44%, 0.06ms invariant (0.08d, 0.88p, 0.70std)	-1.93%, -0.02s invariant (-0.45d, 0.41p, 0.04std)

[jkrumbiegel]

this seems weird to me. Why give a first value at all if it's always shifted back to zero?

[SimonDanisch]

Honestly, I don't know :D This has been there like this, and changing it now would be a breaking change I suppose.