-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect scale and nonlinear values in PlotUtils cgrads #1979
Conversation
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. using time
This PR does not change the using time. ttfp time
This PR does not change the ttfp time. |
CI errors are because of a missing reference image for the new test. |
Alright, I took a deep dive to make sure this is correct now... I guess I misunderstood |
Thanks for taking this forward! On a side note - I wonder if returning a I'm not sure whether [W]GLMakie will accept Sampler (from colorsampler.jl) as a native type but I think something like that might be a somewhat more elegant solution to the problem. |
Yeah we need a refactor of the whole colormap pipeline and then make sure that wherever colormaps are used, they work exactly the same without hacks like we have here |
Description
Fixes #1977
Essentially, reverts a change from #1723.
I'd like to release a v0.16.7 with this change as well. since it is somewhat serious.
Before
(note how they are all the same)
After
Type of change
Delete options that do not apply:
Checklist