-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CairoMakie heatmap filtering #1828
Conversation
* wpx, hpx: projected size of the image in pixels, so the actual width in pixels on screen | ||
* w, h: size of image in pixels | ||
""" | ||
function interpolation_flag(is_vector, interp, wpx, hpx, w, h) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not leave this in a function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the flag logic didn't work anyway, there's no point in switching between the three, there's only two basically. So the main logic isn't about picking the flag but deciding whether to take the fast path or not.
69057bc
to
586ac68
Compare
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. using time
This PR does not change the using time. ttfp time
This PR does not change the ttfp time. |
…e.jl into jk/fix-heatmap-filtering
Description
Heatmap filtering was broken again because it used Cairo.FILTER_BEST, which does nothing in bitmap backends. This PR fixes that and reorders the logic a bit, so it should be easier to follow why the surface or rectangle path is chosen.
Type of change
Checklist