Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map type arguments aren't introspectible in runtime #83

Closed
Tinche opened this issue May 4, 2022 · 0 comments
Closed

Map type arguments aren't introspectible in runtime #83

Tinche opened this issue May 4, 2022 · 0 comments

Comments

@Tinche
Copy link

Tinche commented May 4, 2022

Currently I don't see a way of getting the key and value types from a map type. Ideally, the Map.__class_getitem__ should return an object with __origin__ set to Map and __args__ set to a tuple of the key and value types, so that typing.get_origin() and typing.get_args() work with it.

Without this information, libraries like cattrs have no way of correctly serializing and deserializing Map instances.
@ToBeReplaced ToBeReplaced mentioned this issue Jul 5, 2022
Closed
eltoder added a commit to eltoder/immutables that referenced this issue Mar 4, 2023
@eltoder
Add PEP 585 GenericAlias support
0c58e63 
Also make pure python implementation generic for consistency.

Closes MagicStack#83
@eltoder eltoder mentioned this issue Mar 4, 2023
Merged
eltoder added a commit to eltoder/immutables that referenced this issue Jul 22, 2023
@eltoder
Add PEP 585 GenericAlias support
6b30e74 
Closes MagicStack#83
eltoder added a commit to eltoder/immutables that referenced this issue Jul 22, 2023
@eltoder
Add PEP 585 GenericAlias support
69a14a2 
Closes MagicStack#83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PEP 585 (__class_getitem__ -> GenericAlias) support ToBeReplaced/immutables
1 participant
@Tinche