This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Update vid/pid check in usbDetect.find(...) to check for function callback #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes MadLittleMods#33 by checking if vid or pid are functions
|
Sorry for the delay @erikkallen. Do you still have some interest/time in finishing this up? |
|
Thanks for the updates @erikkallen! We can merge now if you don't want to touch it again. Just thought of a way to make the tests more hands-free, #74 (comment) |
MadLittleMods
changed the title
MadLittleMods
added a commit
that referenced
this pull request
May 9, 2019
|
Thanks for the follow-up @erikkallen ❤️ Sorry again for the delay (just give me a friendly ping if you want some more emphasis in the future). This is now shipped in |
|
Thank you for merging and no worries about the delay, we are all busy people :) thanks again for the awesome package! |
|
Published to npm 🎉 https://www.npmjs.com/package/usb-detection |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33 by checking if vid or pid are functions, currently if only vid and pid are given the pid is made into a callback.