This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Added Windows backslash normalization for instance id's. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it locally in the app I'm working on still and it hasn't failed yet at picking up on any of our Symbol scanners. Not sure if this will have any impact on other devices since I don't know if any other brand of scanners use a slash in their devices' id's. |
MadLittleMods
added a commit
that referenced
this pull request
Nov 24, 2018
|
Thanks @LanetheGreat! Seems to behave normally for my devices in testing. This is shipped in v4.1.0 and will be published to npm in a bit when the prebuilds from CI are done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a local function to normalize slashes in a device's instance id after a call to SetupDiGetDeviceInstanceId and used it after each necessary call.
Closes #64