Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

fixed issue with node 0.10.x #26

Closed
wants to merge 1 commit into from
Closed

fixed issue with node 0.10.x #26

wants to merge 1 commit into from

Conversation

apla
Copy link
Contributor

@apla apla commented Mar 15, 2016

No description provided.

@MadLittleMods
Copy link
Owner

@apla Do the tests pass? Can you outline what versions of node and what OS versions you tested this on? I would really appreciate if you could try the tests on Windows, OSX, and Linux.

@apla
Copy link
Contributor Author

apla commented Mar 16, 2016

Mac OS X 10.11, node 0.10.x — pass,
Windows 10, node 0.12.x — pass,
Windows 8.1, node 5.5.x — pass

Actually I've not changed anything platform specific, only common code. I will test it on linux and Mac OS X with node 4.2.1 tomorrow

@apla
Copy link
Contributor Author

apla commented Mar 17, 2016

Mac OS X 10.11, node 5.0.0 — pass,
Mac OS X 10.11, node 4.2.1 — pass,
Ubuntu Linux 15.10, node 4.3.1 — pass,
Ubuntu Linux 15.10, node 0.10.25 — pass

@apla
Copy link
Contributor Author

apla commented Mar 17, 2016

I've tested multiple devices, USB com port adapter (cp2102), Mass Storage device (USB flash drive), everything is fine

@MadLittleMods
Copy link
Owner

Tests passing on:

  • Windows 10, node@5.5.0
  • OSX 10.11.2, node@4.2.3
  • OSX 10.11.2, node@0.10.43
  • Ubuntu 14.04.03, node@4.4.0 via VM
  • Ubuntu 14.04.03, node@0.10.43 via VM

@MadLittleMods
Copy link
Owner

Merged:

@MadLittleMods
Copy link
Owner

Thank you for the contribution and testing @apla 😀

I just made a release v1.4.0 with these changes!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants