Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-format action, extend gitignore #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vla5924
Copy link
Member

@vla5924 vla5924 commented Sep 14, 2024

No description provided.

@vla5924 vla5924 added the ci label Sep 14, 2024
@vla5924 vla5924 requested a review from aobolensk September 14, 2024 15:02
@vla5924 vla5924 self-assigned this Sep 14, 2024
@vla5924
Copy link
Member Author

vla5924 commented Sep 14, 2024

Demo: https://github.com/ML-acc/triton_acc/actions/runs/10863365027/job/30147430887

I've been using this clang-format-lint-action myself for a long time in https://github.com/vla5924-practice/compiler-project

@vla5924 vla5924 changed the title Add clang-format check and extend gitignore Add clang-format action, extend gitignore Sep 14, 2024
- name: Run clang-format
uses: DoozyX/clang-format-lint-action@v0.17
with:
source: 'include lib python'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better not to limit "source" here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case extensions should be specified

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default extensions set is ok

@vla5924 vla5924 requested a review from a team as a code owner September 17, 2024 15:09
@vla5924 vla5924 requested a review from aobolensk September 17, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants