-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced export functionalities #74
Conversation
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a comment for the SDK, but I’d like to mention it here as well: I think a better name for sectionize_metadata
would be CustomPropertiesSchema
(I imagine camel case fits better here than snake case).
why camel case? It is a method and hence the convention is snake case. |
I'm not sure why I didn't use snake case, but the point still holds. |
sure, the name makes sense and I would rename it in the SDK. Just was wondering about the case schema. |
Maybe |
Changes from this PR:
Previously, the parsed metadata from the source file was represented as a flat dictionary, which will be used e.g. by the dsms python sdk in order to push the entries of the custom properties field.
E.g.
This
plain_metadata
was previously dynamically flattened from thepipeline.general_metadata
:With this release, the
plain_metadata
is depricated and replaced byto_dict
, which can use an additionalcallable
askwarg
in order to transform the schema into a desired shape:with
schema
-kwarg: