Add UTF-16 output capabilities #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When set to Unicode, the output conversion function now can handle characters outside the Basic Multilingual Plane, using UTF-16. The output conversion function will detect whether a value passed in is a low surrogate value and save it in a static variable. If the next character is a correct high surrogate, the function will return the correct unicode character, otherwise it will discard the input.
MARIE uses 16-bit twos complement integers. When the output is set to BIN, the original conversion routine assumes an unsigned integer, resulting in zeros displayed for negative 16-bit twos complement numbers. This patch adds signed-integer conversion and grouping functions so that negative numbers will result in the correct bit pattern.
auroranil
requested changes
Jun 9, 2020
There was a problem hiding this comment.
Nice work! I lack in knowledge when it comes to character encoding, but I hope that my review will improve the way students understand how UTF-16 works.
Also you may want to relabel "UNICODE" to "UNICODE (UTF-16)" for output mode in src/templates/index.ejs.
One question: how would you enter high and low surrogate values in input? Would students have to type in their hexadecimal representation to store the value in memory?
|
I've now fully implemented UTF-16BE (big-endian) and extensively commented the code. I've also added an example that outputs "Hello World!" and some other unicode characters. The example also shows the handling (ignoring) of Byte Order Markers. Should be much cleaner and readable now. |
This patch adds full support for Unicode in the UTF-16BE (big-endian) encoding. It ignores Byte-Order Markers and incorrect surrogate sequences. It also adds a Unicode program to the examples list, which prints out "Hello World" and a couple of emojis outside the Basic Multilingual Plane and a copyright sign as an example of a character inside the BMP.
jhannemann
force-pushed
the
utf-16-output
branch
from
976a91a to
a0547f4
Compare
auroranil
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to issue #288:
When set to Unicode, the output conversion function now can handle
characters outside the Basic Multilingual Plane, using UTF-16.
The output conversion function will detect whether a value passed in
is a high surrogate value and save it in a static variable.
If the next character is a correct low surrogate, the function will
return the correct unicode character, otherwise it will discard the
input.
The following code should output a smiley 🙂: