Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#61 extend each #78

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jolidog
Copy link

@jolidog jolidog commented Jul 26, 2016

Fixes #61 #37 #67

Hi @LukyVj I needed the functionality requested in the previous issues so went ahead and wrote the code.

I'm using the :nth-child(3n + 1) method, where 1 indicates the offset.

Also updated the documentation and made every() an actual alias of each() with a different default starting point. They now use the same logic.

Caveats

  • By providing a default 0 we garante we don't break anyones use of the each() mixin
  • By providing a default of 1 to every() it might break the current use so it's your call to keep them different or not.

@LukyVj
Copy link
Owner

LukyVj commented Aug 2, 2016

Oops I'm sorry, I didn't had time to check before.
I'll take care of it this weekend.

Thanks a lot for this!

@jolidog
Copy link
Author

jolidog commented Aug 19, 2016

@LukyVj I'm assuming you haven't had time to review. Ping me if you need.

@LukyVj
Copy link
Owner

LukyVj commented Oct 23, 2017

Could you please fix the conflict :) ? And I'm mergin it

@mzdr mzdr mentioned this pull request Jun 18, 2018
@lachieh lachieh mentioned this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants