fix: default path for --doc_out_path is the current directory #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back then the default path of doc.json was LOGPATH. However the default path got lost after a refactoring in LuaLS#2821. This commit reimplements the default path, but changes the default to the current directory.
tomlau10
reviewed
Feb 14, 2025
changelog.md
Outdated
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| ## Unreleased | |||
| <!-- Add all new changes here. They will be moved under a version at release --> | |||
| * `FIX` incorrect argument skip pattern for `--check_out_path=`, which incorrectly skips the next argument | |||
| * `FIX` incorrect argument skip pattern for `--check_out_path=`, which incorrectly skips the next argumen | |||
There was a problem hiding this comment.
you seems modified the wrong line
(you incorrectly removed the t from the word argument)
There was a problem hiding this comment.
Thanks. This was a mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3073
Back then the default path of doc.json was LOGPATH. However the default path got lost after a refactoring in #2821. This commit reimplements the default path, but changes the default to the current directory.