-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate grade book #72
Conversation
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
peut etre j ai pas la vision mais pourquoi vous mettez tout en anglais alors pronote c est francais |
C'est par convention de codage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, some stuff needs to be discussed though.
Contrairement à ce que tu peux le croire, pas tous les utilisateurs de PRONOTE parlent français, c'est bien pour ça que PRONOTE dispose d'une version anglaise, espagnole et italienne. Pour s'ouvrir le plus possible aux contributions, LiterateInk et ses librairies restent le pus possible anglophone, d'ailleurs le serveur Discord a pour langue principale l'anglais (même si nous avons des salons à part uniquement en français) |
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Description
Implement the user GradeBook into pawnote.
The class GradeBook will be proposed after.
Important
I have only test on my school instance, some instances can have more or less properties !
So I need data from others instance to make code better with compatibilitie
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Desktop (please complete the following information) :
Checklist:
More:
My API output is here:
output.json