Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate grade book #72

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Conversation

Gabriel29306
Copy link

Description

Implement the user GradeBook into pawnote.
The class GradeBook will be proposed after.

Important

I have only test on my school instance, some instances can have more or less properties !
So I need data from others instance to make code better with compatibilitie

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Using example on my school instance

Test Configuration:

Desktop (please complete the following information) :

  • OS: Linux
  • Version: Lastest

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More:

My API output is here:
output.json

Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
@JyhuKo
Copy link

JyhuKo commented Jan 17, 2025

peut etre j ai pas la vision mais pourquoi vous mettez tout en anglais alors pronote c est francais

@Gabriel29306
Copy link
Author

peut etre j ai pas la vision mais pourquoi vous mettez tout en anglais alors pronote c est francais

C'est par convention de codage

Copy link
Member

@Vexcited Vexcited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some stuff needs to be discussed though.

@Vexcited
Copy link
Member

peut etre j ai pas la vision mais pourquoi vous mettez tout en anglais alors pronote c est francais

Contrairement à ce que tu peux le croire, pas tous les utilisateurs de PRONOTE parlent français, c'est bien pour ça que PRONOTE dispose d'une version anglaise, espagnole et italienne.

Pour s'ouvrir le plus possible aux contributions, LiterateInk et ses librairies restent le pus possible anglophone, d'ailleurs le serveur Discord a pour langue principale l'anglais (même si nous avons des salons à part uniquement en français)

Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
Signed-off-by: Gabriel29306 <ggkervran@outlook.com>
@Vexcited Vexcited merged commit 401f5be into LiterateInk:js Jan 17, 2025
Vexcited added a commit that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants