Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-4743 "Completion notes" instead of "Abandonment notes" is displayed once the user tries to abandon the crop plan. #3697

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

den4ik1203
Copy link
Collaborator

Description

Fix completion notes vs abandonment notes display issue

Jira link:
https://lite-farm.atlassian.net/browse/LF-4743
Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@den4ik1203 den4ik1203 requested review from a team as code owners February 25, 2025 15:23
@den4ik1203 den4ik1203 requested review from Duncan-Brain and kathyavini and removed request for a team February 25, 2025 15:23
@kathyavini
Copy link
Collaborator

kathyavini commented Feb 25, 2025

I noticed that when testing this branch locally, the abandonment notes are not being saved. I think it would be a great learning opportunity for you to figure out why this is happening.

Here are a few questions and hints to help you investigate:

  • What is the purpose of the NOTES constant? What does it do?
  • Are the form values being correctly submitted? (e.g. what does the network request look like when you save the data)
  • This data is saved to the management_plan table so I would recommend taking a look at that as well

Keep up the good work and happy debugging! ☺️

Screenshot 2025-02-25 at 3 44 53 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants