Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claiming rewards with hardware wallet #5486

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Claiming rewards with hardware wallet #5486

merged 3 commits into from
Nov 24, 2023

Conversation

oskarleonard
Copy link
Contributor

What was the problem?

This PR resolves #5484 #5483

How was it solved?

  • Optional chaining of length
  • Fixed darkmode text color

How was it tested?

  1. Performed the Claim flow on HW account which is not a multi sig ✅
  2. Checked for regression as well: Perform the Claim flow on a multisig HW account ✅

@oskarleonard oskarleonard self-assigned this Nov 23, 2023
@ikem-legend ikem-legend self-requested a review November 24, 2023 11:43
@ManuGowda ManuGowda merged commit de6f9d7 into release/3.0.0 Nov 24, 2023
@ManuGowda ManuGowda deleted the claiming-rewards-with-hardware-wallet branch November 24, 2023 12:30
@ManuGowda ManuGowda removed the request for review from eniolam1000752 November 24, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuGowda ManuGowda ManuGowda approved these changes

@ikem-legend ikem-legend ikem-legend approved these changes

Assignees

@oskarleonard oskarleonard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oskarleonard @ManuGowda @ikem-legend