Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dark mode issues #5376

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Fixed dark mode issues #5376

merged 5 commits into from
Oct 12, 2023

Conversation

eniolam1000752
Copy link
Contributor

What was the problem?

This PR resolves #5372

How was it solved?

  • Fix dark mode style on toast
  • Fix crash on account details
  • Fix badge notification on shrunk sidebar

How was it tested?

Test Fix badge notification on shrunk sidebar

  • Shrink the side bar the malfunction on the badge should be gone.
  • On an account with rewards notification badge should be properly seen

Test fix dark mode style on toast

  • Toggle a setting parameter, on dark mode the toast shown should be properly shown

Test fix crash on account details

  • Register a validator, navigate to the account details page, there should be no crash.

oskarleonard
oskarleonard previously approved these changes Oct 12, 2023
@eniolam1000752 eniolam1000752 force-pushed the 5372-fix-dark-mode-issues branch from c7e0924 to d45423e Compare October 12, 2023 10:32
@ManuGowda ManuGowda removed the request for review from ikem-legend October 12, 2023 11:06
@ManuGowda ManuGowda merged commit bbdaf92 into release/3.0.0 Oct 12, 2023
@ManuGowda ManuGowda deleted the 5372-fix-dark-mode-issues branch October 12, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants