Show chainid networkfields on transaction approval #5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarleonard
changed the base branch from
development
to
5141-show-all-chain-ids-trying-to-connect
ManuGowda
reviewed
Jul 19, 2023
ManuGowda
approved these changes
Jul 19, 2023
eniolam1000752
suggested changes
Jul 19, 2023
src/modules/blockchainApplication/connection/components/ConnectionSummary/index.js
Outdated
Show resolved
Hide resolved
ManuGowda
approved these changes
Jul 19, 2023
eniolam1000752
approved these changes
Jul 19, 2023
ManuGowda
deleted the
5140-show-chainid-networkfields-on-transaction-approval
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5140
How was it solved?
Added BlockchainAppDetailsHeader to the RequestSignSummary view
How was it tested?
sign_transactionfrom wallet connect