Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate transaction fee estimate endpoint #5094

Merged
merged 29 commits into from
Aug 10, 2023

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Jun 16, 2023

What was the problem?

This PR resolves #4999 #5110

How was it solved?

  • Implement useTransactionEstimateFees hook
  • consume useTransactionEstimateFees into useTransactionFee hook
  • Separate form errors from transaction error displays
  • Implement dry run on continuing from a form step
  • Fix/update unit tests

How was it tested?

  • JEST
  • Visually

@eniolam1000752 eniolam1000752 added this to the Sprint 101 milestone Jun 16, 2023
@eniolam1000752 eniolam1000752 self-assigned this Jun 16, 2023
@eniolam1000752 eniolam1000752 marked this pull request as draft June 16, 2023 14:21
@eniolam1000752 eniolam1000752 changed the title 4999 integrate tx fee endpoint Integrate transaction fee estimate endpoint Jun 16, 2023
@ManuGowda ManuGowda removed this from the Sprint 101 milestone Jun 19, 2023
@eniolam1000752 eniolam1000752 marked this pull request as ready for review August 8, 2023 23:51
@ManuGowda ManuGowda removed the request for review from ikem-legend August 9, 2023 08:31
Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show feedback on form which doesn't have enough balance to complete the transaction.

STR:

  • have 0.1 balance on wallet
  • initiate register multisignature/register validator/staking
  • check the user has not received any feedback

Copy link
Contributor

@ManuGowda ManuGowda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for fee estimate can we trigger the estimate endpoint once onBlur? so that we do not have api calls until the input is complete?
ex. a user can type 64 char for message and we are calling the endpoint 64 times 😞 so its not optimised.. same applies for amount or any other field which needs blur implementation.

@eniolam1000752 eniolam1000752 force-pushed the 4999-integrate-tx-fee-endpoint branch from 7649152 to 193b0f4 Compare August 10, 2023 13:44
@ManuGowda ManuGowda merged commit efaaa90 into release/3.0.0 Aug 10, 2023
@ManuGowda ManuGowda deleted the 4999-integrate-tx-fee-endpoint branch August 10, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants