-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate transaction fee estimate endpoint #5094
Conversation
src/modules/auth/components/EnterPasswordForm/decryptAccountWorker.js
Outdated
Show resolved
Hide resolved
src/modules/auth/components/EnterPasswordForm/decryptAccountWorker.test.js
Outdated
Show resolved
Hide resolved
src/modules/transaction/hooks/useTransactionFee/useTransactionFee.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show feedback on form which doesn't have enough balance to complete the transaction.
STR:
- have 0.1 balance on wallet
- initiate register multisignature/register validator/staking
- check the user has not received any feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for fee estimate can we trigger the estimate endpoint once onBlur? so that we do not have api calls until the input is complete?
ex. a user can type 64 char for message and we are calling the endpoint 64 times 😞 so its not optimised.. same applies for amount or any other field which needs blur implementation.
7649152
to
193b0f4
Compare
What was the problem?
This PR resolves #4999 #5110
How was it solved?
useTransactionEstimateFees
hookuseTransactionEstimateFees
into useTransactionFee hookHow was it tested?