Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validator and application overview visual issues and validator profile navigation issues #5012

Merged
merged 6 commits into from
May 20, 2023

Conversation

ikem-legend
Copy link
Member

What was the problem?

This PR resolves #5008, #5007 and #5009

How was it solved?

  • Fixed chart legend colours
  • Updated round state icon display
  • Fixed total supply display
  • Fixed empty applications table text
  • Fixed validator profile back button navigation

How was it tested?

  • Visually

@ikem-legend ikem-legend requested a review from ManuGowda May 19, 2023 14:31
@ikem-legend ikem-legend self-assigned this May 19, 2023
@ManuGowda ManuGowda requested a review from sameersubudhi May 19, 2023 15:45
sameersubudhi
sameersubudhi previously approved these changes May 19, 2023
Copy link
Member

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't ran the code but the edits look fine. Also, please consider the following recommendation.

Copy link
Member

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ManuGowda ManuGowda merged commit a245a3c into release/3.0.0 May 20, 2023
@ManuGowda ManuGowda deleted the 5008-validator-overview-visual-issues branch May 20, 2023 10:04
@ManuGowda ManuGowda restored the 5008-validator-overview-visual-issues branch November 17, 2023 17:35
@ManuGowda ManuGowda deleted the 5008-validator-overview-visual-issues branch November 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants