This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Implement mainchain & sidechain recovery verification - Closes #7022 #7166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milenagojkovic
requested review from
ishantiw and
shuse2
and removed request for
mehmetegemen and
mitsuaki-u
shuse2
suggested changes
May 17, 2022
framework/src/modules/interoperability/mainchain/commands/message_recovery.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/mainchain/commands/message_recovery.ts
Show resolved
Hide resolved
shuse2
reviewed
May 18, 2022
framework/test/unit/modules/interoperability/sidechain/commands/message_recovery.spec.ts
Outdated
Show resolved
Hide resolved
framework/src/modules/interoperability/sidechain/commands/message_recovery.ts
Show resolved
Hide resolved
shuse2
approved these changes
May 18, 2022
milenagojkovic
requested review from
mehmetegemen
and removed request for
ishantiw
mehmetegemen
suggested changes
May 19, 2022
framework/test/unit/modules/interoperability/mainchain/commands/message_recovery.spec.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/commands/message_recovery.spec.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/commands/message_recovery.spec.ts
Show resolved
Hide resolved
mehmetegemen
approved these changes
May 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #7022
How was it solved?
Implement mainchain & sidechain recovery verification commands as specified
How was it tested?
Added unit tests