This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 457
Replace epochTime with genesis block timestamp - Closes #5280 #5430
Merged
shuse2
merged 24 commits into
development
from
5280-replace_epochtime_with_genesis_block_timestamp
Jun 16, 2020
Merged
Replace epochTime with genesis block timestamp - Closes #5280 #5430
shuse2
merged 24 commits into
development
from
5280-replace_epochtime_with_genesis_block_timestamp
Jun 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
suggested changes
Jun 16, 2020
shuse2
suggested changes
Jun 16, 2020
nazarhussain
approved these changes
Jun 16, 2020
@pablitovicente LGTM, apart from failing p2p tests. Not sure if it's because of change in this PR. |
Thanks @nazarhussain p2p test failing due to timing after other changes. Another PR is fixing those issues unrelated to these changes. |
shuse2
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5280
How was it solved?
How was it tested?
Unit Tests