Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Replace epochTime with genesis block timestamp - Closes #5280 #5430

Merged

Conversation

pablitovicente
Copy link
Contributor

What was the problem?

This PR resolves #5280

How was it solved?

  • By using a date in the genesis block
  • By adjusting the calculations on slots.ts

How was it tested?

Unit Tests

@pablitovicente pablitovicente marked this pull request as ready for review June 15, 2020 14:06
@nazarhussain
Copy link
Contributor

@pablitovicente LGTM, apart from failing p2p tests. Not sure if it's because of change in this PR.

@pablitovicente
Copy link
Contributor Author

@pablitovicente LGTM, apart from failing p2p tests. Not sure if it's because of change in this PR.

Thanks @nazarhussain p2p test failing due to timing after other changes. Another PR is fixing those issues unrelated to these changes.

@shuse2 shuse2 merged commit bf4cd1f into development Jun 16, 2020
@shuse2 shuse2 deleted the 5280-replace_epochtime_with_genesis_block_timestamp branch June 16, 2020 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace epochTime with genesis block timestamp
3 participants