This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Convert lisk-cryptography tests to jest - Closes #4677 #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change back to format if it(should...) from test(should...)
shuse2
suggested changes
Jan 14, 2020
Update package.json
valamidev
force-pushed
the
4677-cryptography-jest-migration
branch
from
5dc41b1 to
37d6f0c
Compare
shuse2
approved these changes
Jan 15, 2020
mitsuaki-u
reviewed
Jan 15, 2020
mitsuaki-u
approved these changes
Jan 15, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Tests were in mocha.
How did I solve it?
Tests converted to jest.
How to manually test it?
npm run testReview checklist