Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Commit

Permalink
♻️ Remove unwanted test code
Browse files Browse the repository at this point in the history
  • Loading branch information
@ManuGowda
ManuGowda committed May 28, 2020
1 parent 6df8d58 commit 15a9ea1
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 272 deletions.
13 changes: 1 addition & 12 deletions elements/lisk-transactions/src/12_multisignature_transaction.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -220,18 +220,7 @@ export class MultisignatureTransaction extends BaseTransaction {
}

protected validateAsset(): ReadonlyArray<TransactionError> {
const schemaErrors = validator.validate(
multisigRegAssetSchema,
this.asset,
);
const errors = convertToAssetError(
this.id,
schemaErrors,
) as TransactionError[];

if (errors.length > 0) {
return errors;
}
const errors = [];

const { mandatoryKeys, optionalKeys, numberOfSignatures } = this.asset;

Expand Down
44 changes: 0 additions & 44 deletions elements/lisk-transactions/test/10_delegate_transaction.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,50 +105,6 @@ describe('Delegate registration transaction class', () => {
});
});

describe('#validateAsset', () => {
it('should no errors', () => {
const errors = (validTestTransaction as any).validateAsset();
expect(errors).toHaveLength(0);
});

it('should return error when asset includes invalid characters', () => {
const invalidTransaction = {
...validDelegateTransaction,
asset: {
username: '%invalid%username*',
},
};
const transaction = new DelegateTransaction(invalidTransaction);
const errors = (transaction as any).validateAsset();
expect(errors).toHaveLength(1);
});

it('should return error when asset includes uppercase', () => {
const invalidTransaction = {
...validDelegateTransaction,
asset: {
username: 'InValIdUsErNAmE',
},
};
const transaction = new DelegateTransaction(invalidTransaction);
const errors = (transaction as any).validateAsset();
expect(errors).toHaveLength(1);
});

it('should error when asset is potential address', () => {
const invalidTransaction = {
...validDelegateTransaction,
asset: {
username: '1L',
},
};
const transaction = new DelegateTransaction(invalidTransaction);

const errors = (transaction as any).validateAsset();
expect(errors).toHaveLength(1);
});
});

// TODO: Update after updating protocol-specs
describe.skip('#applyAsset', () => {
it('should call state store', async () => {
Expand Down
116 changes: 0 additions & 116 deletions elements/lisk-transactions/test/8_transfer_transaction.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -79,122 +79,6 @@ describe('Transfer transaction class', () => {
});
});

// TODO: Update after updating protocol-specs
describe.skip('#validateAsset', () => {
it('should return no errors with a valid transfer transaction', () => {
const errors = (validTransferTestTransaction as any).validateAsset();
expect(Object.keys(errors)).toHaveLength(0);
});

it('should return error with invalid recipientId', () => {
const transferTransactionWithInvalidRecipientId = new TransferTransaction(
{
...validTransferTransaction,
asset: {
...validTransferTransaction.asset,
recipientId: '123456',
},
},
);
const errors = (transferTransactionWithInvalidRecipientId as any).validateAsset();

expect(errors[0]).toBeInstanceOf(TransactionError);
expect(errors[0].message).toContain(
'\'.recipientId\' should match format "address"',
);
});

it('should return error if recipientId exceed uint64 limit', () => {
const transferTransactionWithInvalidRecipientId = new TransferTransaction(
{
...validTransferTransaction,
asset: {
...validTransferTransaction.asset,
recipientId: '19961131544040416558L',
},
},
);
const errors = (transferTransactionWithInvalidRecipientId as any).validateAsset();

expect(errors).toHaveLength(1);
expect(errors[0]).toBeInstanceOf(TransactionError);
});

it('should return error if recipientId contains leading zeros', () => {
const transferTransactionWithInvalidRecipientId = new TransferTransaction(
{
...validTransferTransaction,
asset: {
...validTransferTransaction.asset,
recipientId: '000123L',
},
},
);
const errors = (transferTransactionWithInvalidRecipientId as any).validateAsset();

expect(errors).toHaveLength(1);
expect(errors[0]).toBeInstanceOf(TransactionError);
});

it('should return error with invalid amount', () => {
const transferTransactionWithInvalidAmount = new TransferTransaction({
...validTransferTransaction,
asset: {
...validTransferTransaction.asset,
amount: '92233720368547758087823474829847337',
},
});
const errors = (transferTransactionWithInvalidAmount as any).validateAsset();

expect(errors[0]).toBeInstanceOf(TransactionError);
expect(errors[0].message).toEqual(
'Amount must be a valid number in string format.',
);
expect(errors[0].dataPath).toEqual('.asset.amount');
});

it('should return error with invalid asset', () => {
const transferTransactionWithInvalidAsset = new TransferTransaction({
...validTransferTransaction,
asset: {
...validTransferTransaction.asset,
data:
'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.',
},
});
const errors = (transferTransactionWithInvalidAsset as any).validateAsset();

expect(errors[0]).toBeInstanceOf(TransactionError);
});

it('should return error if asset data containing null string', () => {
const transferTransactionWithValiddAsset = new TransferTransaction({
...validTransferTransaction,
asset: {
...validTransferTransaction.asset,
data: '\u0000hey:)',
},
});
const errors = (transferTransactionWithValiddAsset as any).validateAsset();

expect(errors).toHaveLength(1);
expect(errors[0]).toBeInstanceOf(TransactionError);
});

it('should return error with asset data containing overflowed string', () => {
const transferTransactionWithInvalidAsset = new TransferTransaction({
...validTransferTransaction,
asset: {
data:
'o2ljg313lzzopdcilxcuy840qzdnmj21hfehd8u63k9jkifpsgxptegi56t8xos现',
},
});
const errors = (transferTransactionWithInvalidAsset as any).validateAsset();

expect(errors[0]).toBeInstanceOf(TransactionError);
});
});

describe('#applyAsset', () => {
it('should return no errors', () => {
const errors = (validTransferTestTransaction as any).applyAsset(store);
Expand Down
10 changes: 0 additions & 10 deletions elements/lisk-transactions/test/base_transaction.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import {
import * as transferFixture from '../fixtures/transaction_network_id_and_change_order/transfer_transaction_validate.json';
import * as secondSignatureReg from '../fixtures/transaction_multisignature_registration/multisignature_registration_2nd_sig_equivalent_transaction.json';
import { defaultAccount, StateStoreMock } from './utils/state_store_mock';
import { serializeSignatures } from '../src/utils';

const getAccount = (account: object): any => {
const object = {
Expand Down Expand Up @@ -261,15 +260,6 @@ describe.skip('Base transaction class', () => {
...validTestTransaction.signatures,
);
});

it('should return a buffer with signatures bytes', () => {
const expectedBuffer = Buffer.concat([
(validTestTransaction as any).getBasicBytes(),
serializeSignatures((validTestTransaction as any).signatures),
]);

expect(validTestTransaction.getBytes()).toEqual(expectedBuffer);
});
});

describe('_validateSchema', () => {
Expand Down
5 changes: 0 additions & 5 deletions elements/lisk-transactions/test/helpers/test_transaction_class.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
*/
/* eslint-disable class-methods-use-this,max-classes-per-file,@typescript-eslint/require-await */
import { BaseTransaction } from '../../src/base_transaction';
import { TransactionJSON } from '../../src/types';
import { TransactionError } from '../../src/errors';

export class TestTransaction extends BaseTransaction {
Expand All @@ -39,10 +38,6 @@ export class TestTransaction extends BaseTransaction {
export class TestTransactionBasicImpl extends BaseTransaction {
public static TYPE = 1;

public validateAsset(): TransactionError[] {
return [];
}

public async applyAsset(): Promise<TransactionError[]> {
return [];
}
Expand Down
5 changes: 0 additions & 5 deletions elements/lisk-transactions/test/utils/index.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
convertBeddowsToLSK,
convertLSKToBeddows,
getId,
serializeSignatures,
prependMinusToPublicKeys,
prependPlusToPublicKeys,
validateSignature,
Expand Down Expand Up @@ -47,9 +46,5 @@ describe('transaction utils', () => {
it('should have verifySignature', () => {
return expect(validateSignature).toBeFunction();
});

it('should have serializeSignatures', () => {
return expect(serializeSignatures).toBeFunction();
});
});
});
71 changes: 0 additions & 71 deletions elements/lisk-transactions/test/utils/signatures_validation.spec.ts
View file

This file was deleted.

24 changes: 15 additions & 9 deletions elements/lisk-transactions/test/utils/state_store_mock.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@
* Removal or modification of this copyright notice is prohibited.
*/
/* eslint-disable @typescript-eslint/explicit-member-accessibility */
import { hexToBuffer } from '@liskhq/lisk-cryptography';
import { Account, TransactionJSON, BlockHeader } from '../../src/types';
import { AccountState, ChainState } from '../../src/base_transaction';

export const defaultAccount = {
publicKey: undefined,
publicKey: Buffer.from(''),
username: null,
isDelegate: 0,
balance: BigInt('0'),
Expand Down Expand Up @@ -71,16 +72,20 @@ export class StateStoreMock {

this.account = {
// eslint-disable-next-line @typescript-eslint/require-await
get: async (address: string): Promise<Account> => {
const account = this.accountData.find(acc => acc.address === address);
get: async (address: Buffer): Promise<Account> => {
const account = this.accountData.find(acc =>
acc.address.equals(address),
);
if (!account) {
throw new Error('Account not defined');
}
return { ...account };
},
// eslint-disable-next-line @typescript-eslint/require-await
getOrDefault: async (address: string): Promise<Account> => {
const account = this.accountData.find(acc => acc.address === address);
getOrDefault: async (address: Buffer): Promise<Account> => {
const account = this.accountData.find(acc =>
acc.address.equals(address),
);
if (!account) {
return { ...defaultAccount, address };
}
Expand All @@ -93,9 +98,9 @@ export class StateStoreMock {
}
return account;
},
set: (address: string, account: Account): void => {
const index = this.accountData.findIndex(
acc => acc.address === address,
set: (address: Buffer, account: Account): void => {
const index = this.accountData.findIndex(acc =>
acc.address.equals(address),
);
if (index > -1) {
this.accountData[index] = account;
Expand All @@ -106,8 +111,9 @@ export class StateStoreMock {
};

this.chain = {
networkIdentifier:
networkIdentifier: hexToBuffer(
additionalInfo?.networkIdentifier ?? defaultNetworkIdentifier,
),
lastBlockHeader: additionalInfo?.lastBlockHeader ?? ({} as BlockHeader),
lastBlockReward: additionalInfo?.lastBlockReward ?? BigInt(0),
get: async (key: string): Promise<Buffer | undefined> =>
Expand Down

0 comments on commit 15a9ea1

Please sign in to comment.