QtVcp: adds tool chooser widget and dialog, add new logging severity and MachineLog view. #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds new "severity" options to the update-machine-log signal "option" parameter. Previously this parameter was just "TIME", "DATE", "INITIAL", or None. Now it may optionally contain a severity after a comma, so e.g. "TIME,ERROR" is valid. To supplement this, I extended the MachineLog widget to optionally provide a new display mode which uses a QTableWidget to display log entries instead of a plain QTextEdit.
tangentaudio
changed the title
|
You have merged master in a couple times. I think it would be better to rebase on master so the additions are all in a row. Can you do that? Otherwise I'll try to get to it this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be used along with the Operator Value Widget, this new dialog will allow the operator to select a tool from the tool table. It can be used to make a friendly manual tool change control where the operator can select the tool from the table rather than having to remember the correct number.
There are also a few minor fixes to Operator Value Widget in this PR as they were developed together.
This PR now also includes changes to extend the 'update-machine-log' signal so that the 'option' parameter can optionally contain a severity field. Previously this field would be e.g. 'TIME' but now is extended to allow a severity to be added by specifying a comma-delimited list, e.g. 'TIME,ERROR'.
I also extended the MachineLog widget to have a new optional way of displaying the machine log with severity, using a QTableWidget. The widget has configurable colors for the various severities that can be set in Designer.