Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pdb install on Windows #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix pdb install on Windows #40

wants to merge 1 commit into from

Conversation

ribtoks
Copy link

@ribtoks ribtoks commented Sep 2, 2023

Closes #29

@ribtoks ribtoks mentioned this pull request Sep 2, 2023
Open
letmaik
letmaik reviewed Sep 2, 2023
View reviewed changes
CMakeLists.txt
@@ -625,7 +625,7 @@ if (LIBRAW_INSTALL)
if(NOT BUILD_SHARED_LIBS AND "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
message("ClangCl does not support pdb generation with static libraries")
elseif(MSVC)
install(FILES ${PROJECT_BINARY_DIR}/raw.pdb ${PROJECT_BINARY_DIR}/raw_r.pdb
install(FILES ${PROJECT_BINARY_DIR}/${CMAKE_BUILD_TYPE}/raw${CMAKE_DEBUG_POSTFIX}.pdb ${PROJECT_BINARY_DIR}/${CMAKE_BUILD_TYPE}/raw_r${CMAKE_DEBUG_POSTFIX}.pdb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSVC is a multi-config generator in CMake for which CMAKE_BUILD_TYPE is not defined/used. See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html.

Copy link
Author

@ribtoks ribtoks Sep 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just used this code and it worked for me. Do you know what should be used instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letmaik letmaik letmaik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[install] Install incorrect pdb name, missing suffix ${CMAKE_DEBUG_POSTFIX}
2 participants
@ribtoks @letmaik