Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth를 통한 로그인 초기구현 완료 추가 정보 입력을 위한 로직 구현이 필요합니다.
예외처리를 포함하여 구현 완료
ouath 및 mail관련 내용 추가
Closed
yechan-kim
reviewed
Oct 14, 2024
src/main/java/com/leets/xcellentbe/domain/user/domain/User.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/email/EmailService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/email/EmailService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/email/EmailService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/email/EmailService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/email/RedisService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/login/AuthController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/login/oauth/CustomOAuthUserService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/login/oauth/OAuthAttributes.java
Outdated
Show resolved
Hide resolved
src/main/java/com/leets/xcellentbe/global/auth/login/oauth/OAuthLoginSuccessHandler.java
Show resolved
Hide resolved
dyk-im
reviewed
Oct 15, 2024
dyk-im
reviewed
Oct 15, 2024
src/main/java/com/leets/xcellentbe/global/auth/email/AuthCodeAlreadySentException.java
Outdated
Show resolved
Hide resolved
dyk-im
reviewed
Oct 15, 2024
기존의 try-catch문을 없애고, GlobalHandlerException이 처리하게 변경하였습니다.
안정성을 위해 null을 return 하지 않는 방식으로 변경하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
OAuth2 및 이메일 인증 관련 로직을 구현 했습니다.
2. 어떤 위험이나 장애를 발견했나요?
OAuth2 관련 로직을 미완성 하였습니다.
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
이메일 인증 구현
5. 추가 사항
OAuth2 관련된 부분은, 일부 구현하였으나 프론트엔드와 협업을 통해 추후 배포서버에서 작동하도록 재구현 할 예정입니다.