Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[add] Transport 'Device' interface for HID&TCP #26

Merged
merged 4 commits into from
Jun 21, 2022
Merged

[add] Transport 'Device' interface for HID&TCP #26

merged 4 commits into from
Jun 21, 2022

Conversation

lpascal-ledger
Copy link
Contributor

And mostly added a keyword argument to the HidDevice.read signature to make it consistent with the interface (def read(self, timeout: int = 1000)).

Also changed the setup.py to automatically fetch the version from sources.

@lpascal-ledger
Copy link
Contributor Author

Also adding some basic checks.

@lpascal-ledger
Copy link
Contributor Author

@jibeee Not sure on this file's diff. I regenerated the protobuf code to add the mypy information, and the _pb2.py changed - despite the .proto being untouched since the beginning of the project.

@lpascal-ledger lpascal-ledger mentioned this pull request Jun 9, 2022
Merged
jibeee
jibeee suggested changes Jun 9, 2022
View reviewed changes
@lpascal-ledger lpascal-ledger requested a review from jibeee June 14, 2022 06:03
@jibeee jibeee merged commit 664bafe into LedgerHQ:master Jun 21, 2022
@lpascal-ledger lpascal-ledger deleted the transport_interface branch June 21, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibeee jibeee jibeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpascal-ledger @jibeee