Add swap support

[Fingolfin69]

Checklist

• App update process has been followed
• Target branch is develop
• Application version has been bumped

Related PRs:

• Sui swap tests: Add Sui swap tests app-exchange#255
• Update app database Add Sui swap support ledger-app-database#317
• Use rust manifest path for reusable build when preparing to upload as library ledger-app-workflows#107

[yogh333]

You shall also add a swap CI workflow so the app is tested against swap feature for any new PR. See for instance here.
As long as you use a fork/branch of the Exchange app, you can specify this branch so we can see if the CI is OK.

[Fingolfin69]

You shall also add a swap CI workflow so the app is tested against swap feature for any new PR. See for instance here. As long as you use a fork/branch of the Exchange app, you can specify this branch so we can see if the CI is OK.

The Swap CI workflow and the other workflows are now passing. However, I had to use a fork for the enforcer workflow to make it use the forked app-database repo/branch in order for it to pass.

Additionally, I created an extra PR to fix what seems to be a bug: LedgerHQ/ledger-app-workflows#107.

I also encountered an issue that seems to need addressing: LedgerHQ/app-exchange#257.

Full list of related PRs:

• Sui swap tests: Add Sui swap tests app-exchange#255
• Update app database Add Sui swap support ledger-app-database#317
• Use rust manifest path for reusable build when preparing to upload as library ledger-app-workflows#107

[yogh333]

You shall also add a swap CI workflow so the app is tested against swap feature for any new PR. See for instance here. As long as you use a fork/branch of the Exchange app, you can specify this branch so we can see if the CI is OK.

The Swap CI workflow and the other workflows are now passing. However, I had to use a fork for the enforcer workflow to make it use the forked app-database repo/branch in order for it to pass.

Ok I have merged the PR about app-database, so you can use LedgerHQ enforcer now

Additionally, I created an extra PR to fix what seems to be a bug: LedgerHQ/ledger-app-workflows#107.

Great, thank you 🙏 , I have reviewed and merged the PR

I also encountered an issue that seems to need addressing: LedgerHQ/app-exchange#257.

I have had a look and to me the number of apps is 64 max and not 16.

Full list of related PRs:

• Sui swap tests: Add Sui swap tests app-exchange#255
• Update app database Add Sui swap support ledger-app-database#317
• Use rust manifest path for reusable build when preparing to upload as library ledger-app-workflows#107

[Fingolfin69]

I have had a look and to me the number of apps is 64 max and not 16.

Yes, it was just changed in recent commit.

[yogh333]

LGTM
Please, could you switch to reusable_swap_functional_tests.yml@develop and remove repo_for_exchange and branch_for_exchange I can merge your PR 🙏 ?

[Fingolfin69]

Please, could you switch to reusable_swap_functional_tests.yml@develop and remove repo_for_exchange and branch_for_exchange I can merge your PR 🙏 ?

Done