Support chatimage protocol #447
Merged
+274
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-yh-china
requested changes
Mar 30, 2025
leaves-server/src/main/java/org/leavesmc/leaves/protocol/chatimage/ChatImageProtocol.java
Outdated
Show resolved
Hide resolved
leaves-server/src/main/java/org/leavesmc/leaves/protocol/chatimage/ServerBlockCache.java
Show resolved
Hide resolved
Lumine1909
force-pushed
the
dev/chatimage
branch
from
21a1f0f to
059a733
Compare
Closed
s-yh-china
requested changes
Apr 5, 2025
leaves-server/src/main/java/org/leavesmc/leaves/protocol/chatimage/ServerBlockCache.java
Outdated
Show resolved
Hide resolved
leaves-server/src/main/java/org/leavesmc/leaves/protocol/chatimage/ServerBlockCache.java
Show resolved
Hide resolved
leaves-server/src/main/java/org/leavesmc/leaves/protocol/chatimage/ChatImageProtocol.java
Show resolved
Hide resolved
leaves-server/src/main/java/org/leavesmc/leaves/protocol/chatimage/ServerBlockCache.java
Outdated
Show resolved
Hide resolved
s-yh-china
requested changes
Apr 5, 2025
leaves-server/src/main/java/org/leavesmc/leaves/protocol/chatimage/ChatImageIndex.java
Outdated
Show resolved
Hide resolved
leaves-server/src/main/java/org/leavesmc/leaves/protocol/chatimage/ChatImageProtocol.java
Outdated
Show resolved
Hide resolved
s-yh-china
approved these changes
Apr 5, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
协议部分很简单 但是由于作者和Paper的一些奇奇怪怪的代码 需要开启这个新的配置项才能使用 并且可能与某些现有的聊天插件冲突
原因解析：
这个mod会在收到聊天并解析时处理发送的玩家 而原版的玩家名会被解析为
MutableComponent（如果你曾经把鼠标放到过玩家名上会发现有悬浮字）而Paper的Adventure处理的方法是直接把玩家的 String name变成 adventure component ，这会导致玩家名和聊天内容一起被解析为 String，mod无法处理消息
因此在Paper及其下游会出现
（我在考虑要不要给Paper或Chatimage发pr处理这个问题