Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use payload and blob structs #1305

Merged
merged 15 commits into from
Feb 24, 2025
Merged

Use payload and blob structs #1305

merged 15 commits into from
Feb 24, 2025

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Feb 21, 2025 •
edited
Loading

Why are these changes needed?

  • This PR puts into use the Payload and Blob structs that were recently implemented

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@litt3
Use payload and blob structs
b8b3d1d 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3 litt3 self-assigned this Feb 21, 2025
@litt3
Make error messages consistent
3700408 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3 litt3 marked this pull request as ready for review February 21, 2025 18:12
litt3 added 3 commits February 21, 2025 16:42
@litt3
Merge branch 'master' into payload-blob-usage
0a9a853
@litt3
Fix merge
dee8b6a 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Fix borked preprod tests
8e85aef 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
samlaf
samlaf reviewed Feb 22, 2025
View reviewed changes
litt3 added 7 commits February 24, 2025 08:52
@litt3
Add comment about blob len
7b9e48e 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Rename method to BlobLengthSymbols
91b8024 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Rename methods to retrieveBlobWithTimeout
cda4b17 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Clarify error message
597b76c 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Add param doc
0ece0db 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Add more TODOs
76dac20 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Merge branch 'master' into payload-blob-usage
d5573e3
@litt3 litt3 requested a review from samlaf February 24, 2025 14:47
litt3 added 3 commits February 24, 2025 12:18
@litt3
Rename codecs package to coretypes
650f680 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Add test doc
3d4b54b 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3
Merge branch 'master' into payload-blob-usage
c73f172 
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
@litt3 litt3 merged commit f4b3ef7 into master Feb 24, 2025
12 checks passed
@litt3 litt3 deleted the payload-blob-usage branch February 24, 2025 17:51
anupsv
anupsv reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@anupsv anupsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsv anupsv anupsv left review comments

@samlaf samlaf samlaf approved these changes

@cody-littley cody-littley cody-littley approved these changes

Assignees

@litt3 litt3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@litt3 @anupsv @samlaf @cody-littley