[TASK] Remove unsetting of routing attribute in middleware #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsetting routing attribute may raise problems in other extensions that depend on it (e.g. tx_news)
|
@Lacr1ma agree. This is a blocker for news. Would be nice if you could enable the issue Tracker :) |
|
Any news on this? |
|
I agree with @rafaelheid-it that the unsetting leads to other errors. For example, GET parameters are no longer taken for links in a language switcher. All links generated with |
|
Fix works for me in V12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Lacr1ma I think it is not a good idea to unset already set attributes in the middleware. Later middlewares may depend on it, if the ExtbaseRouteResolver is not responsible.
Unsetting routing attribute may raise problems in other extensions that depend on it, e.g. tx_news, that depends on it for fetching the news ID in a Request Handler.
Is there any specific reason why the attribute is unset? We could not find any problems when we removed it in our case.