Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce types #229

Merged
merged 7 commits into from
Dec 5, 2022
Merged

Introduce types #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2ca1e53
Introduce sorbet
LTe Feb 6, 2022
53661a6
Add auto-generated types based on YARD
LTe Feb 6, 2022
29ae7f0
Move definitions to main directory
LTe Feb 6, 2022
e5bf408
Ignore types for all files
LTe Dec 4, 2022
ce2afe3
Add sorbet to all tests
LTe Dec 4, 2022
ece394c
Require `sorbet-runtime` for types in code
LTe Dec 5, 2022
95ca526
Add dependencies for sorbet
LTe Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ jobs:
ruby-version: 2.7
bundler-cache: true
- run : bundle exec rake rubocop
typecheck:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
bundler-cache: true
- run : bundle exec srb
test:
runs-on: ubuntu-latest
services:
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ tags
lor
coverage
gemfiles/*.lock
.yard
doc
1 change: 1 addition & 0 deletions .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2.7.1
19 changes: 11 additions & 8 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,19 @@ gem 'activerecord'
gem 'activesupport'
gem 'ancestry'
gem 'railties'
gem 'sorbet-static-and-runtime'

group :development do
gem 'appraisal'
gem 'appraisal', require: false
gem 'coveralls_reborn', require: false
gem 'jeweler'
gem 'pg'
gem 'pry'
gem 'rspec'
gem 'jeweler', require: false
gem 'pg', require: false
gem 'pry', require: false
gem 'rspec', require: false
gem 'rubocop', require: false
gem 'sqlite3'
gem 'timecop'
gem 'yard'
gem 'sord', require: false
gem 'sqlite3', require: false
gem 'tapioca', require: false
gem 'timecop', require: false
gem 'yard', require: false
end
59 changes: 59 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ GEM
ast (2.4.2)
builder (3.2.4)
coderay (1.1.3)
commander (4.6.0)
highline (~> 2.0.0)
concurrent-ruby (1.1.10)
coveralls_reborn (0.25.0)
simplecov (>= 0.18.1, < 0.22.0)
Expand Down Expand Up @@ -84,6 +86,7 @@ GEM
multi_json (1.15.0)
multi_xml (0.6.0)
multipart-post (2.2.3)
netrc (0.11.0)
nokogiri (1.13.9)
mini_portile2 (~> 2.8.0)
racc (~> 1.4)
Expand All @@ -94,6 +97,11 @@ GEM
multi_xml (~> 0.5)
rack (>= 1.2, < 3)
parallel (1.22.1)
parlour (5.0.0)
commander (~> 4.5)
parser
rainbow (~> 3.0)
sorbet-runtime (>= 0.5)
parser (3.1.3.0)
ast (~> 2.4.1)
pg (1.4.5)
Expand All @@ -120,6 +128,12 @@ GEM
zeitwerk (~> 2.5)
rainbow (3.1.1)
rake (13.0.6)
rbi (0.0.16)
ast
parser (>= 2.6.4.0)
sorbet-runtime (>= 0.5.9204)
unparser
rbs (2.8.0)
rchardet (1.8.0)
rdoc (6.4.0)
psych (>= 4.0.0)
Expand Down Expand Up @@ -158,10 +172,45 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)
sorbet (0.5.10564)
sorbet-static (= 0.5.10564)
sorbet-runtime (0.5.10564)
sorbet-static (0.5.10564-universal-darwin-14)
sorbet-static (0.5.10564-universal-darwin-15)
sorbet-static (0.5.10564-universal-darwin-16)
sorbet-static (0.5.10564-universal-darwin-17)
sorbet-static (0.5.10564-universal-darwin-18)
sorbet-static (0.5.10564-universal-darwin-19)
sorbet-static (0.5.10564-universal-darwin-20)
sorbet-static (0.5.10564-universal-darwin-21)
sorbet-static (0.5.10564-universal-darwin-22)
sorbet-static (0.5.10564-x86_64-linux)
sorbet-static-and-runtime (0.5.10564)
sorbet (= 0.5.10564)
sorbet-runtime (= 0.5.10564)
sord (5.0.0)
commander (~> 4.5)
parlour (~> 5.0)
rbs (~> 2.0)
sorbet-runtime
yard
spoom (1.1.13)
sorbet (>= 0.5.9204)
sorbet-runtime (>= 0.5.9204)
thor (>= 0.19.2)
sqlite3 (1.5.4)
mini_portile2 (~> 2.8.0)
stringio (3.0.2)
sync (0.5.0)
tapioca (0.10.3)
bundler (>= 1.17.3)
netrc (>= 0.11.0)
parallel (>= 1.21.0)
rbi (~> 0.0.0, >= 0.0.16)
sorbet-static-and-runtime (>= 0.5.9892)
spoom (~> 1.1.0, >= 1.1.11)
thor (>= 1.2.0)
yard-sorbet
term-ansicolor (1.7.1)
tins (~> 1.0)
thor (1.2.1)
Expand All @@ -172,13 +221,20 @@ GEM
tzinfo (2.0.5)
concurrent-ruby (~> 1.0)
unicode-display_width (2.3.0)
unparser (0.6.5)
diff-lcs (~> 1.3)
parser (>= 3.1.0)
webrick (1.7.0)
yard (0.9.28)
webrick (~> 1.7.0)
yard-sorbet (0.7.0)
sorbet-runtime (>= 0.5)
yard (>= 0.9)
zeitwerk (2.6.6)

PLATFORMS
ruby
x86_64-linux

DEPENDENCIES
activerecord
Expand All @@ -192,7 +248,10 @@ DEPENDENCIES
railties
rspec
rubocop
sorbet-static-and-runtime
sord
sqlite3
tapioca
timecop
yard

Expand Down
Loading