Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet even more docstrings #445

Merged
merged 14 commits into from
Aug 13, 2024
Merged

Yet even more docstrings #445

merged 14 commits into from
Aug 13, 2024

Conversation

marcpaterno
Copy link
Collaborator

No description provided.

@marcpaterno marcpaterno requested a review from vitenti July 29, 2024 21:59
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.4%. Comparing base (a6c217a) to head (efdb90e).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #445     +/-   ##
========================================
- Coverage    98.5%   98.4%   -0.1%     
========================================
  Files          48      48             
  Lines        3667    3666      -1     
========================================
- Hits         3612    3611      -1     
  Misses         55      55             
Files with missing lines Coverage Δ
...recrown/likelihood/binned_cluster_number_counts.py 98.5% <ø> (-0.1%) ⬇️
firecrown/likelihood/gaussfamily.py 99.4% <100.0%> (ø)
firecrown/likelihood/gaussian.py 100.0% <100.0%> (ø)
firecrown/likelihood/likelihood.py 99.2% <ø> (ø)
firecrown/likelihood/number_counts.py 91.1% <100.0%> (ø)
firecrown/likelihood/supernova.py 100.0% <ø> (ø)
firecrown/likelihood/two_point.py 98.3% <ø> (ø)

mypy 1.11.0 complains about unused type: ignore statements
that are required by earlier versions, causing failures.
This commit should be reverted once the CI system has moved
to using the newer version of mypy (at which time the type:
ignore statements that cause the failure will have to be
removed).
@marcpaterno marcpaterno merged commit bd70476 into master Aug 13, 2024
9 checks passed
@marcpaterno marcpaterno deleted the yet-even-more-docstrings branch August 13, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants