Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster example implementing SDSS cluster number counts and mean masses. #443

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

yyzhang
Copy link

@yyzhang yyzhang commented Jul 18, 2024

Cluster example implementing SDSS cluster number counts and mean masses.

  1. Updated syntaxes in "demo_sacc_for_clusters.ipynb" to work with new syntaxes.

  2. Generate SACC file that correspond to SDSS cluster observables.

  • Implemented a "generate_SDSS_ClusterCountsMass_sacc_data.py" in examples to generate new SACC file corresponding to SDSS cluster counts and mean masses.
  • But not sure how to test this file
  • Also thought that this could be merged into generate_rich_mean_mass_sacc_data.py as a separate function to be called by the main code.
  1. Configure osmosis and fire crown to work with SDSS SACC file
  • New osmosis ini file: cluster_SDSS_counts_mean_mass_redshift_richness.ini
  • New python file to be used by Firecrown likelihood: cluster_SDSS_redshift_richness.py

@yyzhang yyzhang requested review from vitenti, m-aguena and combet July 18, 2024 12:45

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
vitenti Sandro Dias Pinto Vitenti

Verified

This commit was signed with the committer’s verified signature.
vitenti Sandro Dias Pinto Vitenti
…om:LSSTDESC/firecrown into cluster_example_fixingSaccDemo_2024retreat

Verified

This commit was signed with the committer’s verified signature.
vitenti Sandro Dias Pinto Vitenti

Verified

This commit was signed with the committer’s verified signature.
vitenti Sandro Dias Pinto Vitenti

Verified

This commit was signed with the committer’s verified signature.
vitenti Sandro Dias Pinto Vitenti

Verified

This commit was signed with the committer’s verified signature.
vitenti Sandro Dias Pinto Vitenti
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (9185e57) to head (c51e2f1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          50       50           
  Lines        4608     4608           
  Branches      507      507           
=======================================
  Hits         4608     4608           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vitenti
Copy link
Collaborator

vitenti commented Mar 21, 2025

Thank @yyzhang for the additional example. We just updated the interface and included it in the test suit. Please tell us if it is OK to mark as ready for review and merge it.

… parameter space. Max_mass of 16.0 gives frequent errors when trying to run the chain
@yyzhang yyzhang marked this pull request as ready for review March 24, 2025 03:01
@yyzhang
Copy link
Author

yyzhang commented Mar 24, 2025

Thanks, I changed the status to ready for review! It is ready to be merged.

I have included one minor change to the integration range of the likelihood function associated with this example, to make it more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants