-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster example implementing SDSS cluster number counts and mean masses. #443
base: master
Are you sure you want to change the base?
Conversation
… in generate_rich_mean_mass_sacc_data.py
…r (N+M)
…om:LSSTDESC/firecrown into cluster_example_fixingSaccDemo_2024retreat
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 50 50
Lines 4608 4608
Branches 507 507
=======================================
Hits 4608 4608 🚀 New features to boost your workflow:
|
Thank @yyzhang for the additional example. We just updated the interface and included it in the test suit. Please tell us if it is OK to mark as ready for review and merge it. |
… parameter space. Max_mass of 16.0 gives frequent errors when trying to run the chain
Thanks, I changed the status to ready for review! It is ready to be merged. I have included one minor change to the integration range of the likelihood function associated with this example, to make it more robust. |
Cluster example implementing SDSS cluster number counts and mean masses.
Updated syntaxes in "demo_sacc_for_clusters.ipynb" to work with new syntaxes.
Generate SACC file that correspond to SDSS cluster observables.