Fix apply PAPI method

LMBishop · Mar 4, 2025 · da0e62c · da0e62c
1 parent 40b5448
commit da0e62c
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/bukkit/src/main/java/com/leonardobishop/quests/bukkit/BukkitQuestsPlugin.java b/bukkit/src/main/java/com/leonardobishop/quests/bukkit/BukkitQuestsPlugin.java
@@ -979,11 +979,10 @@ public boolean isPrimaryThread() {
         return Bukkit.isPrimaryThread();
     }
 
-    private final WeakHashMap<Player, Pattern> playerPatternMap = new WeakHashMap<>();
+    private static final Pattern PLAYER_PATTERN = Pattern.compile("\\{player}");
 
     /**
-     * Applies {player} internal placeholder (using cache for patterns) and PAPI placeholders
-     * for the player while respecting the plugin config.
+     * Applies {player} internal placeholder and PAPI placeholders for the player while respecting the plugin config.
      *
      * @param type type of config option
      * @param player the player to apply placeholders for
@@ -998,8 +997,7 @@ public boolean isPrimaryThread() {
 
         // Handle internal {player} replacement
         if (player != null) {
-            final Pattern pattern = this.playerPatternMap.computeIfAbsent(player, key -> Pattern.compile('{' + key.getName() + '}', Pattern.LITERAL));
-            str = pattern.matcher(str).replaceAll(player.getName());
+            str = PLAYER_PATTERN.matcher(str).replaceAll(player.getName());
         }
 
         // Handle PlaceholderAPI placeholders