-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GroupBy Class and Aggregation Mechanism #85
Merged
slabasan
merged 16 commits into
LLNL:develop
from
michaelmckinsey1:feature-groupby_aggregate
Nov 28, 2023
Merged
Add GroupBy Class and Aggregation Mechanism #85
slabasan
merged 16 commits into
LLNL:develop
from
michaelmckinsey1:feature-groupby_aggregate
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
84c7bec
to
10ac42a
Compare
slabasan
approved these changes
Oct 27, 2023
f3c3cdd
to
ea70a0b
Compare
…tead of Groupby object
5ba8b76
to
998f91f
Compare
Yejashi
pushed a commit
to TauferLab/thicket
that referenced
this pull request
Mar 6, 2024
* Add license * Use select_dtypes function instead of pandas api functions * Remove optional columns and rename 'aux' to 'other' * Update docstring * Black * rename variables * Remove assumption of only 2 levels * Improve accuracy to pandas by returning Thicket from agg function instead of Groupby object * Update docstrings * Black * Add metadata aggregation back in * Fix bug with setting index when columns are in perfdata * Update API to match pandas API for func argument * Add unit test * Rename function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-thicket
Issues and PRs involving Thicket's core Thicket datastructure and associated classes
priority-normal
Normal priority issues and PRs
status-ready-for-review
This PR is ready to be reviewed by assigned reviewers
type-feature
Requests for new features or PRs which implement new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
GroupBy
object to Thicket, which will be returned as a result of usingThicket.groupby
. This object also has an aggregation mechanismGroupBy.agg()
that can be used to aggregate the Thickets in the Groupby object into a single Thicket.