Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GroupBy Class and Aggregation Mechanism #85

Merged
merged 16 commits into from
Nov 28, 2023

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Aug 30, 2023

Summary

This PR adds a new GroupBy object to Thicket, which will be returned as a result of using Thicket.groupby. This object also has an aggregation mechanism GroupBy.agg() that can be used to aggregate the Thickets in the Groupby object into a single Thicket.

@michaelmckinsey1
Copy link
Collaborator Author

michaelmckinsey1 commented Aug 30, 2023

Need to add unit tests f3c3cdd

@michaelmckinsey1 michaelmckinsey1 added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features labels Aug 30, 2023
@michaelmckinsey1 michaelmckinsey1 added this to the 2023.3.1 milestone Aug 30, 2023
@michaelmckinsey1 michaelmckinsey1 force-pushed the feature-groupby_aggregate branch from 84c7bec to 10ac42a Compare September 8, 2023 19:25
@michaelmckinsey1 michaelmckinsey1 removed this from the 2023.3.1 milestone Sep 27, 2023
@slabasan slabasan added this to the 2023.3.1 milestone Sep 29, 2023
@michaelmckinsey1 michaelmckinsey1 added status-work-in-progress PR is currently being worked on and removed status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels Oct 9, 2023
@michaelmckinsey1 michaelmckinsey1 added status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed status-work-in-progress PR is currently being worked on labels Oct 16, 2023
@michaelmckinsey1 michaelmckinsey1 force-pushed the feature-groupby_aggregate branch from f3c3cdd to ea70a0b Compare November 1, 2023 17:38
Michael Richard McKinsey and others added 2 commits November 17, 2023 17:31
@michaelmckinsey1 michaelmckinsey1 force-pushed the feature-groupby_aggregate branch from 5ba8b76 to 998f91f Compare November 18, 2023 01:31
@slabasan slabasan merged commit 5444204 into LLNL:develop Nov 28, 2023
@michaelmckinsey1 michaelmckinsey1 deleted the feature-groupby_aggregate branch December 8, 2023 00:33
Yejashi pushed a commit to TauferLab/thicket that referenced this pull request Mar 6, 2024
* Add license

* Use select_dtypes function instead of pandas api functions

* Remove optional columns and rename 'aux' to
'other'

* Update docstring

* Black

* rename variables

* Remove assumption of only 2 levels

* Improve accuracy to pandas by returning Thicket from agg function instead of Groupby object

* Update docstrings

* Black

* Add metadata aggregation back in

* Fix bug with setting index when columns are in perfdata

* Update API to match pandas API for func argument

* Add unit test

* Rename function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants