Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug When Reading Directories #203

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

#163 Introduced a bug when providing a directory of Caliper files that causes an error. Providing a list of files or a single file still works. This PR adds regression tests for this so we will catch it next time.

@michaelmckinsey1 michaelmckinsey1 added area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-high High priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Aug 7, 2024
@michaelmckinsey1 michaelmckinsey1 self-assigned this Aug 7, 2024
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM.

@pearce8 this PR is ready for your review.

@ilumsden ilumsden added status-approved No more revisions are required on this PR and it is ready for merge and removed status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels Aug 12, 2024
@slabasan slabasan added this to the 2024.1.1 milestone Sep 4, 2024
@slabasan slabasan merged commit e956f5a into LLNL:develop Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-thicket Issues and PRs involving Thicket's core Thicket datastructure and associated classes priority-high High priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants