Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Indexing Issue in Tree for MultiIndex #197

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

#181 introduced a bug for MultiIndex columns on this line, when trying to index the dataframe. The user can specifying the name column using a tuple or we automatically select the right column when name_column is the default argument. This PR also adds a unit test for this case so we can tell if another change breaks MultiIndex printing.

@michaelmckinsey1 michaelmckinsey1 added area-visualization Issues and PRs involving any of Thicket's provided visualizations priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Jul 22, 2024
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jul 22, 2024
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pearce8 please review and merge as soon as you are able. I am actively running into the bug that this fixes in the DDR vs HBM work.

@pearce8 pearce8 merged commit a4adea6 into LLNL:develop Jul 29, 2024
4 checks passed
@slabasan slabasan added this to the 2024.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-visualization Issues and PRs involving any of Thicket's provided visualizations priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants