Optimize Loop in Unify #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmckinsey1
added
area-thicket
michaelmckinsey1
added
status-ready-for-review
ilumsden
requested changes
Jun 26, 2024
thicket/ensemble.py
Outdated
| for cur_id, cur_node in old_to_new.items(): | ||
| new_id = id(cur_node) | ||
| if new_id in temp_dict: | ||
| old_to_new[cur_id] = temp_dict[new_id] |
There was a problem hiding this comment.
Never update the thing you are iterating over. You may get lucky, but 9 times out of 10, this is at best undefined behavior.
There was a problem hiding this comment.
Good catch I messed up when converting it from a function a1479b3
|
@pearce8 this PR is ready for your review |
ilumsden
added
status-approved
michaelmckinsey1
force-pushed
the
opt-merge_dicts
branch
from
304a416 to
f1e0e4e
Compare
pearce8
approved these changes
Jun 27, 2024
michaelmckinsey1
added a commit
to michaelmckinsey1/thicket
that referenced
this pull request
Jul 9, 2024
* Optimize double for loop * Remove functions * Fix bug * Improve variable names for clarity * Change list to set * Rm space
michaelmckinsey1
added a commit
to michaelmckinsey1/thicket
that referenced
this pull request
Jul 9, 2024
* Optimize double for loop * Remove functions * Fix bug * Improve variable names for clarity * Change list to set * Rm space
Yejashi
pushed a commit
to TauferLab/thicket
that referenced
this pull request
Sep 4, 2024
* Optimize double for loop * Remove functions * Fix bug * Improve variable names for clarity * Change list to set * Rm space
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
_merge_dictsand_replace_graph_df_nodesby removing the functions and putting the code inline.old_to_newandtemp_dictfromO(n^2)toO(n). This was an oversight during original implementation.The performance improvements of this PR are documented in #170. #170 avoids needing to merge dictionaries as it only calls
concat_thicketswith 2 Thickets, however using theconcat_thicketsfunction with 3 or more Thickets will still benefit from this PR.This PR is better for fewer files with many nodes, while #170 is better for many files since it avoids merging
old_to_newandtemp_dict.