Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New Positional Argument to Unit Test #179

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add New Positional Argument to Unit Test #179

merged 1 commit into from
Jun 20, 2024

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jun 20, 2024 •
edited
Loading

The change in #168 made it necessary to add a new positional argument in the unit tests for the _fill_perfdata argument.

@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review June 20, 2024 20:26
@michaelmckinsey1 michaelmckinsey1 requested a review from pearce8 June 20, 2024 20:30
@michaelmckinsey1 michaelmckinsey1 self-assigned this Jun 20, 2024
@michaelmckinsey1 michaelmckinsey1 added area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Jun 20, 2024
@pearce8 pearce8 merged commit 6af7005 into LLNL:develop Jun 20, 2024
4 checks passed
@slabasan slabasan modified the milestones: 2024.3.0, 2023.3.1, 2024.2.0 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearce8 pearce8 pearce8 approved these changes

Assignees

@michaelmckinsey1 michaelmckinsey1

Labels
area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Milestone
2024.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelmckinsey1 @pearce8 @slabasan