Overhaul of Distance Based Scoring Functions #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We discovered that the current implementation of Bhattacharyya and Hellinger scoring functions does not fully capture the intended behavior. These distance metrics only return a magnitude, providing no indication of the direction or preference in the comparison. As a result, it becomes unclear what the values represent in terms of scoring.
To address this, we've introduced functionality to assign a sign to the distance metrics. This allows the scoring functions to not only return the magnitude of the difference between two samples but also indicate a preference or direction through the signage. This enhancement gives users a clearer interpretation of the results.
Key Updates