Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: built-in configuration page link extension #176

Merged
merged 1 commit into from
Jun 28, 2024
Merged

docs: built-in configuration page link extension #176

merged 1 commit into from
Jun 28, 2024

Conversation

guspan-tanadi
Copy link
Contributor

A link in Generating Data page having extension as html as followed by other link.

@ilumsden ilumsden requested review from ilumsden and slabasan June 28, 2024 16:32
ilumsden
ilumsden approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@ilumsden ilumsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pearce8 this is a minor URL fix for our docs, so I'd argue that we can go ahead and merge this before Stephanie's back.

@ilumsden ilumsden added area-docs Issues and PRs related to Thicket's documentation, notebooks, and examples priority-normal Normal priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Jun 28, 2024
@pearce8 pearce8 merged commit 609fa5e into LLNL:develop Jun 28, 2024
4 checks passed
@guspan-tanadi guspan-tanadi deleted the builtinpagelink branch June 29, 2024 04:42
michaelmckinsey1 pushed a commit to michaelmckinsey1/thicket that referenced this pull request Jul 9, 2024
@guspan-tanadi @michaelmckinsey1
docs: built-in configuration page link extension (LLNL#176)
e12b5ae
michaelmckinsey1 pushed a commit to michaelmckinsey1/thicket that referenced this pull request Jul 9, 2024
@guspan-tanadi @michaelmckinsey1
docs: built-in configuration page link extension (LLNL#176)
04653ed
Yejashi pushed a commit to TauferLab/thicket that referenced this pull request Sep 4, 2024
@guspan-tanadi @Yejashi
docs: built-in configuration page link extension (LLNL#176)
a7651d3
@slabasan slabasan added this to the 2024.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilumsden ilumsden ilumsden approved these changes

@slabasan slabasan Awaiting requested review from slabasan

Assignees
No one assigned
Labels
area-docs Issues and PRs related to Thicket's documentation, notebooks, and examples priority-normal Normal priority issues and PRs status-approved No more revisions are required on this PR and it is ready for merge type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Milestone
2024.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@guspan-tanadi @ilumsden @slabasan @pearce8