update stats notebook with new violin plot example #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iolinplot_thicket changes
Yejashi
added
status-ready-for-review
|
@Yejashi does this PR correspond with LLNL/thicket-tutorial#44? |
|
@ilumsden yes |
ilumsden
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
LGTM.
This PR essentially just copies the modifications to 04_stats-functions.ipynb from LLNL/thicket-tutorial#44 into the docs.
@Yejashi to avoid any confusion, you should NOT remove the outputs from this version of the notebook. Outputs should be present for the notebooks going into the thicket repo, and they should be removed from notebooks going into the thicket-tutorial repo. Essentially, don't apply the feedback I made in LLNL/thicket-tutorial#44 to this PR.
@pearce8 this PR is ready for your review.
ilumsden
added
status-approved
pearce8
approved these changes
Jun 28, 2024
michaelmckinsey1
pushed a commit
to michaelmckinsey1/thicket
that referenced
this pull request
Jul 9, 2024
…iolinplot_thicket changes (LLNL#165)
michaelmckinsey1
pushed a commit
to michaelmckinsey1/thicket
that referenced
this pull request
Jul 9, 2024
…iolinplot_thicket changes (LLNL#165)
Yejashi
added a commit
to TauferLab/thicket
that referenced
this pull request
Sep 4, 2024
…iolinplot_thicket changes (LLNL#165)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively a continuation of @slabasan 's PR #155 since i cannot access the update-stats-notebook-violinplot branch.