Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds violin plot functionality along with testing #141

Merged
merged 23 commits into from
Apr 8, 2024

Conversation

Yejashi
Copy link
Collaborator

@Yejashi Yejashi commented Mar 6, 2024

Created two functions in order to plot violin plots.

The first function is designed to take in a singular thicket object, and plot user defined nodes and columns. The x-axis would be each node, and the y-axis would be the column metric specified by the user

The second function is designed to take in more than one thicket object, were we plot a node for each thicket, and the y-axis would be the data for each node. There are a few key things that are enforced. First, all thickets passed in needs to have the same columnar index level. Each thicket only gets one node to plot.

Both functions support custom percentile lines that would be user defined, as well as line styles and line colors.

@Yejashi Yejashi changed the title Display violinplot Adds violin plot functionality along with testing Mar 6, 2024
@Yejashi Yejashi force-pushed the display_violinplot branch from d326312 to b56b56b Compare March 6, 2024 03:09
@Yejashi Yejashi added area-stats Issues and PRs related to Thicket's stats subpackage priority-normal Normal priority issues and PRs status-work-in-progress PR is currently being worked on type-feature Requests for new features or PRs which implement new features labels Mar 6, 2024
@Yejashi Yejashi requested a review from ilumsden March 6, 2024 04:48
@Yejashi Yejashi self-assigned this Mar 6, 2024
@Yejashi Yejashi added status-ready-for-review This PR is ready to be reviewed by assigned reviewers and removed status-work-in-progress PR is currently being worked on labels Mar 6, 2024
@Yejashi Yejashi requested a review from slabasan March 6, 2024 17:50
@Yejashi Yejashi force-pushed the display_violinplot branch from 250c2cd to 5efce34 Compare March 14, 2024 03:59
Copy link
Collaborator

@slabasan slabasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall @Yejashi! Just a couple small changes.

@slabasan slabasan merged commit 012c89c into LLNL:develop Apr 8, 2024
4 checks passed
@Yejashi Yejashi deleted the display_violinplot branch May 1, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-stats Issues and PRs related to Thicket's stats subpackage priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants