-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds violin plot functionality along with testing #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d326312
to
b56b56b
Compare
…ng calculated values into separate columns (LLNL#103) * Changed percentiles.py to take in custom values, and split calulated values into seperate columns * Updated doc string for function * Updated percentile.py to pass black and flake8 * Updating percentile unit testing * Updated formatting for unit testing * code cleanup * percentiles: add test for percentiles=None --------- Co-authored-by: Stephanie Brink <brink2@llnl.gov>
250c2cd
to
5efce34
Compare
slabasan
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall @Yejashi! Just a couple small changes.
slabasan
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-stats
Issues and PRs related to Thicket's stats subpackage
priority-normal
Normal priority issues and PRs
status-ready-for-review
This PR is ready to be reviewed by assigned reviewers
type-feature
Requests for new features or PRs which implement new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created two functions in order to plot violin plots.
The first function is designed to take in a singular thicket object, and plot user defined nodes and columns. The x-axis would be each node, and the y-axis would be the column metric specified by the user
The second function is designed to take in more than one thicket object, were we plot a node for each thicket, and the y-axis would be the data for each node. There are a few key things that are enforced. First, all thickets passed in needs to have the same columnar index level. Each thicket only gets one node to plot.
Both functions support custom percentile lines that would be user defined, as well as line styles and line colors.