Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Extra-P Unit Tests to Match Latest Release #115

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Nov 29, 2023

The Latest releases of Extra-P (4.1.1+) have more precise modeling components for some functions. So the current unit test for componentizing the functions needs to be updated since there will be more terms to be expected. The unit tests are now abstracted since the same thing may happen in the future.

@michaelmckinsey1 michaelmckinsey1 added area-tests Issues and PRs involving Thicket's automated tests area-extrap Issues and PRs involving Thicket's support for Extra-P priority-high High priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs labels Nov 29, 2023
@slabasan slabasan merged commit af45082 into LLNL:develop Dec 5, 2023
@michaelmckinsey1 michaelmckinsey1 deleted the fix-extrap_4.1.2 branch December 8, 2023 00:33
Yejashi pushed a commit to TauferLab/thicket that referenced this pull request Mar 6, 2024
* Update unit test

* Generalize unit tests as models can change results in the future.

* Fix flake errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-extrap Issues and PRs involving Thicket's support for Extra-P area-tests Issues and PRs involving Thicket's automated tests priority-high High priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-bug Identifies bugs in issues and identifies bug fixes in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants