Excise loop exec #1549
Merged
Excise loop exec #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBurmark
approved these changes
Sep 29, 2023
rchen20
reviewed
Sep 29, 2023
| policy, explicit atomic policies. | ||
| any | ||
| auto_atomic seq_exec, Atomic operation *compatible* with | ||
| any OpenMP loop execution policy. See example |
There was a problem hiding this comment.
Is the "Atomic operation compatible with loop execution policy" mentioned in the comment referring to loop_exec?
There was a problem hiding this comment.
I don't understand the question? There is no longer any mention of loop_exec.
rchen20
reviewed
Sep 29, 2023
Comment on lines
+783
to
+784
| auto_atomic seq_exec, Atomic operation *compatible* with | ||
| any OpenMP loop execution policy. See example |
There was a problem hiding this comment.
Maybe this might be more clear?
Suggested change
| auto_atomic seq_exec, Atomic operation *compatible* with | |
| any OpenMP loop execution policy. See example | |
| auto_atomic seq_exec, Atomic operation *compatible* with | |
| any OpenMP most execution policies. See example |
There was a problem hiding this comment.
It works will ALL loop execution policies. https://github.com/LLNL/RAJA/blob/develop/include/RAJA/policy/atomic_auto.hpp#L41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary