Remove uses of ManagedArray::getActiveBasePointer #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adayton1
commented
Feb 6, 2025
| if (size > 1) { | ||
| // Bounds checking is only available with the resource manager because the ManagedArray::size() is not |
There was a problem hiding this comment.
This is no longer true - ManagedArray::size() always works now.
adayton1
commented
Feb 6, 2025
| bool warned = false; | ||
|
|
||
| if (dataSize < size) { | ||
| const char* dataName = CHAICallback::getName(dataRecord); |
There was a problem hiding this comment.
The name isn't that important now that we have a backtrace.
adayton1
commented
Feb 6, 2025
| warned = true; | ||
| } | ||
|
|
||
| if (!inPlace) { | ||
| const chai::PointerRecord* outDataRecord = chai::ArrayManager::getInstance()->getPointerRecord((void *)outData.data(chai::ExecutionSpace::CPU, false)); | ||
| int outDataSize = dataRecord->m_size/sizeof(T); |
There was a problem hiding this comment.
Also note that outDataSize was actually wrong (it should have been pulled from outDataRecord).
liu15
approved these changes
Feb 6, 2025
dtaller
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManagedArray::getActiveBasePointer will be removed from CHAI soon, so preparing for that update.